406: http://reviewboard/dashboard/?sort=-time_added sorts by Last Updated
- Fixed
- Review Board
| bela.******@gmai***** (Google Code) (Is this you? Claim this profile.) | |
 |
|
| April 20, 2009 |
What's the URL of the page containing the problem? http://reviewboard.eng.vmware.com/dashboard/ What steps will reproduce the problem? 1. Click on the "Posted" column heading to sort by it. 2. Manually go to <http://reviewboard.eng.vmware.com/dashboard/?sort=- time_added> in an attempt to force the issue. 3. Give up. What is the expected output? What do you see instead? Expect it to be sorted by "Posted"; it insists on being sorted according to the Last Updated column. What operating system are you using? What browser? Same results with WinXP + Opera 9.23, WinXP + Firefox 2.0.0.12, and VMware ESX Server 3.0.1 console OS + Lynx 2.8.5dev.7. It's definitely a server-side problem. Please provide any additional information below.
This is certainly not happening on any dashboard I've seen. Are you still seeing this? Both the Posted Time and Posted Time Since columns are working perfectly here.
On the other hand, "Last Updated" doesn't sort correctly because datagrids can only sort on database fields, and not on things computed from those fields. *ahem*
I think we should address the Last Updated field by actually storing a timestamp on the ReviewRequest and updating it when we change something in a review. This will make it faster, too, since I think that's a major cause of slowdown in the dashboard right now.
I demand data to back up your preposterous accusations!
Output from `w3m http://...?sort=-time_added`, heavily edited to remove most identifying marks while still showing times and enough marks that someone who had access to VMware's internal reviewboard could figure it out. This was collected a few minutes ago from live data. Notice that it claims to be sorted on the "Posted" column. The actual order is neither according to Posted nor Last Updated, it seems to follow one of those for a while then get distracted by a butterfly and follow the other order for a while. If formatting gets trashed then I guess I'll fool around with "Attach a file"... All Incoming Review Requests New Posted Last Updates Summary Submitter (Descending) Updated ... Starred Unsort March 11th, 2 hours, 49 o Manual Crossport of CS: 582087 from... (masked) 2008, 10:31 minutes ago p.m. March 11th, 8 hours, 44 o Update doc, examples, reference code (masked) 2008, 4:45 minutes ago p.m. March 9th, 13 hours, 4 o Reject broadcast addr as (masked) (masked) 2008, 11:31 minutes ago p.m. March 10th, 5 hours, 30 o Implementing Processor Profile. (masked) 2008, 5:49 minutes ago a.m. February 1 day, 12 o py...(masked) (masked) 28th, 2008, hours ago 5:40 p.m. February 3 days, 14 o py...(masked) (masked) 28th, 2008, hours ago 5:48 p.m. February 3 days, 10 o py... utilities (masked) (masked) 28th, 2008, hours ago 5:47 p.m. March 7th, 4 days, 6 o Install ... relative path (masked) 2008, 12:35 hours ago a.m. March 7th, 3 days, 15 o Enable official builds...(masked) (masked) 2008, 3:14 hours ago
I was talking to Christian re: data, but thanks for this information!
-
+ Component-Dashboard + Milestone-Release1.0
Should be fixed now in r1917. We actually use real database fields now for the column and sorting appears to work correctly.
-
+ Fixed -
+ chipx86